mirror of
https://gitlab.com/Anson-Projects/zine.git
synced 2025-06-15 13:16:39 +00:00
Fixes #9, turns out id's are important
This commit is contained in:
parent
caa0100e26
commit
65998c7fa7
@ -18,12 +18,9 @@ const toggleModal = (event) => {
|
||||
event.preventDefault();
|
||||
const modal = document.getElementById(event.currentTarget.dataset.target);
|
||||
if (!modal) return;
|
||||
modal && (isModalOpen(modal) ? closeModal(modal) : openModal(modal));
|
||||
modal && (modal.open ? closeModal(modal) : openModal(modal));
|
||||
};
|
||||
|
||||
// Is modal open
|
||||
const isModalOpen = (modal) => modal.hasAttribute("open") && modal.getAttribute("open") !== "false";
|
||||
|
||||
// Open modal
|
||||
const openModal = (modal) => {
|
||||
const { documentElement: html } = document;
|
||||
@ -36,7 +33,7 @@ const openModal = (modal) => {
|
||||
visibleModal = modal;
|
||||
html.classList.remove(openingClass);
|
||||
}, animationDuration);
|
||||
modal.setAttribute("open", true);
|
||||
modal.showModal();
|
||||
};
|
||||
|
||||
// Close modal
|
||||
@ -47,7 +44,7 @@ const closeModal = (modal) => {
|
||||
setTimeout(() => {
|
||||
html.classList.remove(closingClass, isOpenClass);
|
||||
html.style.removeProperty(scrollbarWidthCssVar);
|
||||
modal.removeAttribute("open");
|
||||
modal.close();
|
||||
}, animationDuration);
|
||||
};
|
||||
|
||||
|
@ -89,7 +89,7 @@ fn generate_header() -> Markup {
|
||||
li { h1 { "The Biggs Brief" }}
|
||||
}
|
||||
ul {
|
||||
li { button data-target="about" onclick="toggleModal(event)" { "About" } }
|
||||
li { button data-target="modal-about" onclick="toggleModal(event)" { "About" } }
|
||||
li {
|
||||
|
||||
}
|
||||
@ -123,11 +123,11 @@ fn about_modal(entries: Vec<utilities::Post>) -> Markup {
|
||||
links.sort();
|
||||
|
||||
html! {
|
||||
dialog id="about" {
|
||||
dialog id="modal-about" {
|
||||
article {
|
||||
header {
|
||||
a href="#" aria-label="Close" rel="prev" {}
|
||||
p { strong { "About" }}
|
||||
button aria-label="Close" rel="prev" data-target="modal-about" onclick="toggleModal(event)" {}
|
||||
h3 { "About" }
|
||||
}
|
||||
p {
|
||||
"I couldn't find a RSS reader that I liked so I decided to build my own."
|
||||
|
Loading…
x
Reference in New Issue
Block a user